install feature is always on, add install-to-disk
#987
+71
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
cfg-install-to-disk
branch
from
614b14f to
43fcd89
Compare
I consider `bootc install to-filesystem` support a key feature of bootc. In theory today one can still set up a system directly with `ostree` and we will continue to support that. But things like logically bound images we do want to be initialized from the start and that's with `bootc install to-filesystem`. Maintaining the feature just has a logistical annoyance any time one touches the install code as we often end up needing to carefully `#[cfg(feature = "install")]` in many places in an infectious way. Also as we head towards enabling factory reset containers#404 we really do want some of the install code enabled there. However, `to-disk` is much more of a "demo". I don't want bootc to grow too much knowledge around block devices. Complex setups (LVM, LUKS) etc. are the domain of external installers and provisioning tools. So the feature gate is now on that (which is still on by default). We ended up with more `#[cfg(feature = "install-to-disk")]` than I'd have liked, but some of that can be fixed subsequently. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
cfg-install-to-disk
branch
from
43fcd89 to
3e6ea48
Compare
|
Rebased 🏄 for trivial conflict with #990 |
|
/packit retest-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I consider
bootc install to-filesystemsupport a key feature of bootc. In theory today one can still set up a system directly withostreeand we will continue to support that.But things like logically bound images we do want to be initialized from the start and that's with
bootc install to-filesystem.Maintaining the feature just has a logistical annoyance any time one touches the install code as we often end up needing to carefully
#[cfg(feature = "install")]in many places in an infectious way.Also as we head towards enabling factory reset
#404
we really do want some of the install code enabled there.
However,
to-diskis much more of a "demo". I don't want bootc to grow too much knowledge around block devices. Complex setups (LVM, LUKS) etc. are the domain of external installers and provisioning tools.So the feature gate is now on that (which is still on by default).
We ended up with more
#[cfg(feature = "install-to-disk")]than I'd have liked, but some of that can be fixed subsequently.