Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/bootc-install: Give more guidance on root= and rootflags= #972

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

cgwalters
Copy link
Collaborator

We need to change Anaconda and bootc-image-builder to stop generating /etc/fstab for this reason.

We need to change Anaconda and bootc-image-builder to stop
generating `/etc/fstab` for this reason.

Signed-off-by: Colin Walters <[email protected]>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a workaround to avoid the remount service from failing?

Outside of the discoverable partition model, a common baseline default for installers is to set `root=UUID=`
(and optionally `rootflags=`) kernel arguments as machine specific state.
When using `install to-filesystem`, you should provide these as explicit
kernel arguments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give an example? This stuff is outside my comfort zone, so having some example would increase my understanding.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section of the document is targeted at people doing generic installers, disk image image generation tools and custom installs in general.

There's multiple ways to set kernel arguments that are described in the docs already right?

@cgwalters
Copy link
Collaborator Author

Is there a workaround to avoid the remount service from failing?

No, unfortunately.

I commented in https://bugzilla.redhat.com/show_bug.cgi?id=2332319#c1 which should cover the Anaconda case you hit. We can link that as a known bug until Anaconda is updated.

The change that would be by far the easiest/biggest impact would be to change the systemd fstab generator to handle this but I've hesitated to raise it there as I think conceptually it's more that the fstab is wrong.

@vrothberg
Copy link
Member

I commented in https://bugzilla.redhat.com/show_bug.cgi?id=2332319#c1 which should cover the Anaconda case you hit. We can link that as a known bug until Anaconda is updated.

Love that!

@vrothberg vrothberg merged commit fa37e1c into containers:main Dec 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants