Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Remove tmt bootc plugin code and use released bootc plugin #938

Merged
merged 1 commit into from
Dec 7, 2024
Merged

test: Remove tmt bootc plugin code and use released bootc plugin #938

merged 1 commit into from
Dec 7, 2024

Conversation

henrywang
Copy link
Contributor

Remove tests-intetration folder because TMT bootc plugin replaces tests-integration

@cgwalters
Copy link
Collaborator

Thanks for looking at this! I had started on a similar patch but it started to get big and so I did just #937

These don't logically conflict but let's land 937 first?

@henrywang henrywang changed the title test: Remove tmt bootc plugin code and use released bootc plugin WIP: test: Remove tmt bootc plugin code and use released bootc plugin Dec 5, 2024
@henrywang
Copy link
Contributor Author

henrywang commented Dec 5, 2024 •
edited
Loading

These don't logically conflict but let's land 937 first?

Yes. 937 first.

@henrywang henrywang force-pushed the update_integration branch 4 times, most recently from 0cc649d to 304c35a Compare December 5, 2024 16:25
@cgwalters
Copy link
Collaborator

Hmm but now we entirely lost the tmt tests running on PRs here?

@henrywang
Copy link
Contributor Author

henrywang commented Dec 5, 2024 •
edited
Loading

Hmm but now we entirely lost the tmt tests running on PRs here?

It should be packit github app issue. I make a rebase, packit jobs appear again.

@cgwalters
Copy link
Collaborator

Test jobs seem dead now with

fatal: not a git repository (or any parent up to mount point /)

@henrywang henrywang force-pushed the update_integration branch 10 times, most recently from 918d0e4 to bc99412 Compare December 7, 2024 05:39
@henrywang
test: Remove tmt bootc plugin code and use released bootc plugin
3aada94 
Remove tests-intetration folder because TMT bootc plugin replaces
tests-integration

Signed-off-by: Xiaofeng Wang <[email protected]>
@henrywang henrywang changed the title WIP: test: Remove tmt bootc plugin code and use released bootc plugin test: Remove tmt bootc plugin code and use released bootc plugin Dec 7, 2024
@henrywang henrywang requested a review from cgwalters December 7, 2024 07:40
@henrywang
Copy link
Contributor Author

henrywang commented Dec 7, 2024 •
edited
Loading

Yes! I got everything works now. And the tmt plan logs can be found from plans/integration/data/test-tmt-log/ folder (e.g https://artifacts.dev.testing-farm.io/867c5092-b84d-40f5-9ef7-6b250ddf3616/work-integrationc8p1tnkd/plans/integration/data/test-tmt-log/)

And this will be one example/user case of image mode testing with Testing Farm and TMT bootc plugin.

cgwalters
cgwalters approved these changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cgwalters cgwalters merged commit cb99e15 into containers:main Dec 7, 2024
26 checks passed
@henrywang henrywang deleted the update_integration branch December 8, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrywang @cgwalters