install: Two prep changes for pulling bound images at install time #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split up: - Initialize empty sysroot - Install container to sysroot This makes it easier to do more things that still reference the sysroot. (The git diff for this change is...really nice IMO, very straightforward) Signed-off-by: Colin Walters <[email protected]>
ckyrouac
approved these changes
Jul 18, 2024
Huh, hadn't seen that one before...oh oh wait, I know. |
Prep for further changes. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
bound-install-time-prep
branch
from
b23ec3e to
5a0b50d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code similar to this was part of the original #559 - this is prep for pulling bound images at install time
install: Split internal main phase into two
Split up:
This makes it easier to do more things that still
reference the sysroot.
(The git diff for this change is...really nice IMO,
very straightforward)
Signed-off-by: Colin Walters [email protected]
install: Change helper to return deployment too
Prep for further changes.
Signed-off-by: Colin Walters [email protected]