-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Add a new bootc image subcommand #620
Conversation
This is aimed to close the biggest gap in https://containers.github.io/bootc/booting-local-builds.html - because then we can easily add something like This builds on ostreedev/ostree-rs-ext#642 which has notes about its inefficiencies. |
OK yes, this PR also hit the install flake (I added it to #579 )
With the new size printing we can clearly see that the partition size is just 1M. I'm going to add some more logging to see if I can figure out more here. |
b6a015b
to
655ee1e
Compare
OK this one now has a test based on the framework added in #625 |
5c5b02a
to
b777459
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I´d love to see docs (no blocker) and like to bikeshed a bit on the naming of push
. It feels more like a write-to-storage
or something down these lines.
92d9568
to
f1c8355
Compare
I've updated that, though note that right now this is hidden from the CLI as an experimental feature so we can use it in our own CI, and stabilize things later.
The default is indeed like That said...it would actually simplify things perhaps if we only supported There's also the longer term bikeshed topic of (assuming we made it actually efficient and not a physical copy) if the default should actually be to keep the bootc image visible in containers-storage or so. |
Agreed, that sounds like a good idea 👍 |
cee62b0
to
e252383
Compare
OK it's now called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!
We have a basic `bootc image list` but more interesting is `bootc image push` which defaults to copying the booted image into the container storage. Signed-off-by: Colin Walters <[email protected]>
We might as well roll in a bunch of things into this "local container build changes" test. I wanted to get some coverage for kargs, so this adds some. Signed-off-by: Colin Walters <[email protected]>
Drop the transport support; we only support copying to `containers-storage`. Anyone who wants to push directly to a remote registry can do so by first copying to containers-storage and then pushing via e.g. `podman` or `skopeo`. Signed-off-by: Colin Walters <[email protected]>
e252383
to
83a6a15
Compare
I dropped the conflicting logging change to kargs from here for now, will split it out separately. |
…-1.0.80 build(deps): bump anyhow from 1.0.79 to 1.0.80
Add docker-archive transport
We have a basic
bootc image list
but more interesting isbootc image push
which defaults to copying the bootedimage into the container storage.
Signed-off-by: Colin Walters [email protected]