-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install_t again #284
Fix install_t again #284
Conversation
We shouldn't perform global system mutation without an opt-in. As painful as it is. Signed-off-by: Colin Walters <[email protected]>
Hardcoding `install_t` is a bit ugly; maybe at some point things change so that `spc_t` has `install_t` privileges. Let's do a runtime check if we can set an invalid label; if so then we're good. Signed-off-by: Colin Walters <[email protected]>
Skipping CI for Draft Pull Request. |
I realized we were silently falling back to |
This was the thing that was breaking our `unconfined_t` -> `install_t` transition; the host `/tmp` is `nosuid`. It simplifies things here to just make our own, so do that. Signed-off-by: Colin Walters <[email protected]>
Another important thing in this change is that instead of trying to just check the security context is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I didn't know about the /proc/1/root
trick, interesting!
lsm: Make setenforce 0 fallback require
BOOTC_SETENFORCE0_FALLBACK
We shouldn't perform global system mutation without an opt-in.
As painful as it is.
Signed-off-by: Colin Walters [email protected]
lsm: Test if we have install_t capability
Hardcoding
install_t
is a bit ugly; maybe at some pointthings change so that
spc_t
hasinstall_t
privileges.Let's do a runtime check if we can set an invalid label; if
so then we're good.
Signed-off-by: Colin Walters [email protected]
lsm: Make a not-
nosuid
/tmp
This was the thing that was breaking our
unconfined_t
->install_t
transition; the host
/tmp
isnosuid
. It simplifies thingshere to just make our own, so do that.
Signed-off-by: Colin Walters [email protected]