Fail if systemd generation failed and it's explicitly set

Fix #675 If we explicitly set to generate systemd with parameters, fail the module if the generation failed. Signed-off-by: Sagi Shnaidman <[email protected]>
containers · Nov 30, 2023 · fb27f88 · fb27f88
1 parent c3b38b5
commit fb27f88
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/plugins/module_utils/podman/common.py b/plugins/module_utils/podman/common.py
@@ -142,6 +142,8 @@ def generate_systemd(module, module_params, name, version):
     if rc != 0:
         module.log(
             "PODMAN-CONTAINER-DEBUG: Error generating systemd: %s" % err)
+        if sysconf:
+            module.fail_json(msg="Error generating systemd: %s" % err)
         return result
     else:
         try:
@@ -194,6 +196,8 @@ def generate_systemd(module, module_params, name, version):
         except Exception as e:
             module.log(
                 "PODMAN-CONTAINER-DEBUG: Error writing systemd: %s" % e)
+            if sysconf:
+                module.fail_json(msg="Error writing systemd: %s" % e)
             return result