playground tests

[lmilbaum]

No description provided.

[lmilbaum]

The following test throws an error which I'm still debugging:

================================================================================ ERRORS =================================================================================
____________________________________________________________ ERROR collecting playground/tests/test_alive.py ____________________________________________________________
/opt/app-root/lib64/python3.11/site-packages/pluggy/_hooks.py:501: in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
/opt/app-root/lib64/python3.11/site-packages/pluggy/_manager.py:119: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
/opt/app-root/lib64/python3.11/site-packages/_pytest/python.py:276: in pytest_pycollect_makeitem
    return list(collector._genfunctions(name, obj))
/opt/app-root/lib64/python3.11/site-packages/_pytest/python.py:489: in _genfunctions
    self.ihook.pytest_generate_tests.call_extra(methods, dict(metafunc=metafunc))
/opt/app-root/lib64/python3.11/site-packages/pluggy/_hooks.py:562: in call_extra
    return self._hookexec(self.name, hookimpls, kwargs, firstresult)
/opt/app-root/lib64/python3.11/site-packages/pluggy/_manager.py:119: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
playground/tests/conftest.py:7: in pytest_generate_tests
    pytest_container.auto_container_parametrize(metafunc)
/opt/app-root/lib64/python3.11/site-packages/pytest_container/helpers.py:36: in auto_container_parametrize
    raise ValueError(
E   ValueError: The test function test_alive is using the auto_container fixture but the parent module is not setting the 'CONTAINER_IMAGES' variable
======================================================================== short test summary info ========================================================================
ERROR playground/tests/test_alive.py - ValueError: The test function test_alive is using the auto_container fixture but the parent module is not setting the 'CONTAINER_IMAGES' variable

[cgwalters]

I think this makes sense. Overall comment is it could use a brief high level architecture description (possibly in the Makefile?) or a separate readme.md.

[rhatdan]

@MichaelClifford PTAL

[MichaelClifford]

Suggested change

	run: install models/llama-2-7b-chat.Q5_K_S.gguf
	run: install download

[MichaelClifford]

Is there a way to check if the model exists before downloading it? We don't want people re-downloading the model each time the use make run

[lmilbaum]

Yes. It is possible. I would prefer implementing it in a followup PR if that is not a critical change.

[MichaelClifford]

Can we use this instead? https://huggingface.co/TheBloke/Mistral-7B-v0.1-GGUF/resolve/main/mistral-7b-v0.1.Q2_K.gguf
Its smaller model (3gb) and has an apache license.

[lmilbaum]

That is doable. But, I would prefer implementing it on a followup PR.

[sallyom]

LGTM!! Thank you @lmilbaum this is really great and so much work to keep updating with the repo restructuring!!