Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump python 3.11 to 3.12 #517

Merged
merged 1 commit into from
Jun 6, 2024
Merged

bump python 3.11 to 3.12 #517

merged 1 commit into from
Jun 6, 2024

Conversation

Gregory-Pereira
Copy link
Collaborator

@lmilbaum
Copy link
Collaborator

CI is broken

@lmilbaum
Copy link
Collaborator

Not sure all the relevant CI workflows were triggered

@Gregory-Pereira
Copy link
Collaborator Author

They were not, not sure we have correct build trigger rules. I will try to fix CI when I get time.

@sallyom
Copy link
Collaborator

sallyom commented Jun 2, 2024

moduleNotFoundError: No module named 'distutils' - error w/ CI build

@Gregory-Pereira
bump python 3.11 to 3.12
5dd5a57 
Signed-off-by: greg pereira <[email protected]>
@Gregory-Pereira Gregory-Pereira force-pushed the bump-all-python-base-images-to-312 branch from 340611e to 5dd5a57 Compare June 5, 2024 20:47
@Gregory-Pereira
Copy link
Collaborator Author

huggingface_hub module does not have support for python3.12, downgrading the model_converter.

rhatdan
rhatdan approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 4cb9a41 into main Jun 6, 2024
6 checks passed
@Gregory-Pereira Gregory-Pereira mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhatdan rhatdan rhatdan approved these changes

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford MichaelClifford is a code owner

@sallyom sallyom Awaiting requested review from sallyom sallyom is a code owner

@lmilbaum lmilbaum Awaiting requested review from lmilbaum lmilbaum is a code owner

@cgwalters cgwalters Awaiting requested review from cgwalters cgwalters is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gregory-Pereira @lmilbaum @sallyom @rhatdan