Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ilab container builds #509

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

Gregory-Pereira
Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira force-pushed the fix-ilab-build-workflows branch 2 times, most recently from a9d31e0 to 6ca1848 Compare May 23, 2024 05:45
@markmc
Copy link
Contributor

markmc commented May 23, 2024

Are you intentionally reverting @rhatdan's move to OCI transport in #427 ?

@Gregory-Pereira
Copy link
Collaborator Author

Yes I was. Because that change broke all of our workflows which automatically produce our ai-lab ilab based images. Because of this our e2e runs have not worked. Although I guess a potential alternative implementation would be swapping CI to work with an action build rather than a make command ... But I wanted to keep our automation + CI as closely aligned to our average user experience as possible.

@rhatdan
Copy link
Member

rhatdan commented May 25, 2024

We need these to be stored as OCI images for speed of building and saving of disk space. Lets work on some other mechanism to fix the ci sysem.

@Gregory-Pereira
Copy link
Collaborator Author

Understood, ill update my implementation shortly.

@Gregory-Pereira Gregory-Pereira force-pushed the fix-ilab-build-workflows branch 4 times, most recently from f3595fe to ec862bb Compare May 29, 2024 17:18
@Gregory-Pereira Gregory-Pereira changed the title fix workflow due to --layers + --squash-all Fix Ilab container builds May 29, 2024
This implementation should preserve the OCI transfer implementaiton

Signed-off-by: greg pereira <[email protected]>
@Gregory-Pereira Gregory-Pereira force-pushed the fix-ilab-build-workflows branch 7 times, most recently from 48bc575 to 69f090a Compare May 29, 2024 18:19
@Gregory-Pereira Gregory-Pereira force-pushed the fix-ilab-build-workflows branch 3 times, most recently from 2b43d2d to 894f5a7 Compare May 29, 2024 18:58
@lmilbaum
Copy link
Collaborator

CI is broken

@Gregory-Pereira Gregory-Pereira force-pushed the fix-ilab-build-workflows branch from 894f5a7 to bb44d08 Compare May 29, 2024 19:25
@Gregory-Pereira Gregory-Pereira marked this pull request as draft June 8, 2024 22:16
@cooktheryan
Copy link
Collaborator

@rhatdan @lmilbaum @Gregory-Pereira in regards to the e2e/ilab testing will we keep maintaining this or will this go into official repos such as the rhelai repository?

@rhatdan
Copy link
Member

rhatdan commented Jun 15, 2024

I think we should keep the project as an open project, so the Training bits should stay here.

@cooktheryan
Copy link
Collaborator

Will try to prioritize the stability of the e2e tests then next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants