Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap granite for mistral cleanup + model and recipe housekeeping #350

Conversation

Gregory-Pereira
Copy link
Collaborator

Should close out #311
/cc @containers/ai-lab-recipes-maintainers

@Gregory-Pereira Gregory-Pereira force-pushed the 311-swap-granite-for-mistral-cleanup branch from 4052562 to a21af62 Compare April 27, 2024 19:04
@Gregory-Pereira Gregory-Pereira added the models Anything related to models (upgrades, swap, etc) label Apr 27, 2024
@Gregory-Pereira Gregory-Pereira force-pushed the 311-swap-granite-for-mistral-cleanup branch 3 times, most recently from 0d448c5 to 9809020 Compare April 28, 2024 01:57
@rhatdan
Copy link
Member

rhatdan commented Apr 28, 2024

Needs a rebase.

@Gregory-Pereira Gregory-Pereira force-pushed the 311-swap-granite-for-mistral-cleanup branch from 9809020 to 84d747c Compare April 28, 2024 17:01
@Gregory-Pereira
Copy link
Collaborator Author

Unblocked post rebase, waiting for tests.

@rhatdan
Copy link
Member

rhatdan commented Apr 29, 2024

LGTM
Merge when tests ready.

@Gregory-Pereira Gregory-Pereira force-pushed the 311-swap-granite-for-mistral-cleanup branch from 84d747c to fcb16cf Compare April 29, 2024 21:51
@Gregory-Pereira
Copy link
Collaborator Author

Unblocked @MichaelClifford

Copy link
Collaborator

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gregory-Pereira Gregory-Pereira merged commit 2b94847 into containers:main Apr 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models Anything related to models (upgrades, swap, etc) ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants