include common directory in tests on path changes #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregory-Pereira
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum and
cgwalters
as code owners
Gregory-Pereira
force-pushed
the
include-common-directories-in-tests-paths
branch
7 times, most recently
from
f8cbaf1 to
2c3b906
Compare
|
Tests pass, going to add the |
|
Can confirm that the labels to skip tests work. Removing |
|
/retest |
empty commit testing `hold-tests` label succeeds, squashing Signed-off-by: greg pereira <[email protected]>
Gregory-Pereira
force-pushed
the
include-common-directories-in-tests-paths
branch
from
eab60c4 to
42d30ea
Compare
lmilbaum
reviewed
Apr 14, 2024
| @@ -22,6 +24,7 @@ env: | |||
|
|
|||
| jobs: | |||
| build-and-push-image: | |||
| if: "!contains(github.event.pull_request.labels.*.name, 'hold-tests')" | |||
There was a problem hiding this comment.
Not sure folks would remember to use this trick
There was a problem hiding this comment.
I was going to have a discussion with the team about it. I know I would use it because sometime I just want to see the diff for review purposes and dont want to waist the resources. If your worried about visibility maybe we could tag every PR with hold-tests to begin with and then use a /ok-to-test similar to prow?
lmilbaum
reviewed
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing tests, will also use this PR to fix any code changes that correspond to failing tests.
Broken out from #258.
Changes:
hold-testslabel, I thought this could save us some resourcescodegen'sDownload modelstep due changing make target namechromedriverandchromedownloads failling due to timeout/recipes/common/bininstallmake target in bothrecipes/commonand each recipe to be a double colon rule rather than a single colon rule, which allows us to run common and local install commands together