Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not system reset --force on nocache containerfiles #231

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Do not system reset --force on nocache containerfiles #231

merged 1 commit into from
Apr 10, 2024

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Apr 10, 2024

No description provided.

@rhatdan
Copy link
Member Author

rhatdan commented Apr 10, 2024

@cgwalters @Gregory-Pereira @sallyom @MichaelClifford @ygalblum @vrothberg @giuseppe PTAL

sallyom
sallyom approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@sallyom sallyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same review as #230 :) if someone can chime in that this works, I'll tag/merge - and tests will be in place for this within next few days
LGTM

@sallyom sallyom merged commit 1964c56 into containers:main Apr 10, 2024
5 checks passed
@mrguitar
Copy link

Thanks @rhatdan. I can confirm this is working on my side as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sallyom sallyom sallyom approved these changes

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford MichaelClifford is a code owner

@lmilbaum lmilbaum Awaiting requested review from lmilbaum lmilbaum is a code owner

@cgwalters cgwalters Awaiting requested review from cgwalters cgwalters is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhatdan @mrguitar @sallyom