Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provision with Ansible #214

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Provision with Ansible #214

merged 1 commit into from
Apr 11, 2024

Conversation

lmilbaum
Copy link
Collaborator

@lmilbaum lmilbaum commented Apr 10, 2024

Migrated the provisioning from user data script (cloud init) to ansible playbook. With this change, it is known when the provision is done. The need to sleep for an estimate time is no longer required.

@lmilbaum lmilbaum self-assigned this Apr 10, 2024
@lmilbaum lmilbaum force-pushed the provision branch 16 times, most recently from 5dabb27 to 8aba1fa Compare April 10, 2024 17:22
@lmilbaum lmilbaum force-pushed the provision branch 12 times, most recently from af0ea74 to f8f961c Compare April 10, 2024 19:15
@lmilbaum lmilbaum force-pushed the provision branch 3 times, most recently from d5f01d7 to 5094db7 Compare April 10, 2024 19:41
@lmilbaum lmilbaum marked this pull request as ready for review April 10, 2024 19:41
Signed-off-by: Liora Milbaum <[email protected]>
Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have next to no anisible experience but overall it looks good.

@rhatdan
Copy link
Member

rhatdan commented Apr 10, 2024

Me neither, but feel free to merge.

@lmilbaum lmilbaum merged commit 289cff4 into main Apr 11, 2024
5 checks passed
@lmilbaum lmilbaum deleted the provision branch April 11, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants