fixing llamacpp pytyon docs and makefile #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregory-Pereira
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum and
cgwalters
as code owners
rhatdan
reviewed
Apr 5, 2024
rhatdan
reviewed
Apr 5, 2024
|
|
||
| .PHONY: test | ||
| test: | ||
| pytest --log-cli-level NOTSET | ||
| pytest --log-cli-level NOTSET |
There was a problem hiding this comment.
Should the tests also do a make all on this Makefile?
There was a problem hiding this comment.
we can add in a follow-up @lmilbaum
There was a problem hiding this comment.
I have added a version of this, let me know if I should remove it
rhatdan
reviewed
Apr 5, 2024
|
|
||
| ```bash | ||
| make -f Makefile models/mistral-7b-instruct-v0.1.Q4_K_M.gguf | ||
| make -f Makefile mistral-7b-instruct-v0.1.Q4_K_M.gguf |
There was a problem hiding this comment.
Make mistral and llama variables defined above.
There was a problem hiding this comment.
Does this implementation look acceptable? I feel like users should be able to trigger a download without knowing the full model name
sallyom
reviewed
Apr 5, 2024
sallyom
reviewed
Apr 5, 2024
Gregory-Pereira
force-pushed
the
fix-llammacpp-ms-docs-and-make
branch
from
7a31c9e to
7346200
Compare
|
LGTM |
Signed-off-by: greg pereira <[email protected]>
Gregory-Pereira
force-pushed
the
fix-llammacpp-ms-docs-and-make
branch
from
7346200 to
2cf35c1
Compare
|
Forgot to update the workflows, I will add those changes now. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of sepereating out #132 /cc @MichaelClifford @sallyom @rhatdan