Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spin Model Server in chatbot recipe #126

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Spin Model Server in chatbot recipe #126

merged 1 commit into from
Apr 1, 2024

Conversation

lmilbaum
Copy link
Collaborator

@lmilbaum lmilbaum commented Mar 31, 2024 •
edited
Loading

  1. As long as the repository source tree is dynamic, it would be preferable to invoke the functional tests on every change.
  2. Spin the model server container when testing chatbot app

@lmilbaum lmilbaum self-assigned this Mar 31, 2024
@lmilbaum lmilbaum force-pushed the chatbot branch 4 times, most recently from fda3617 to 8cd80ba Compare March 31, 2024 14:39
@lmilbaum lmilbaum marked this pull request as ready for review March 31, 2024 14:43
@lmilbaum lmilbaum force-pushed the chatbot branch 21 times, most recently from e930720 to cae2b11 Compare March 31, 2024 20:02
@lmilbaum lmilbaum force-pushed the chatbot branch 25 times, most recently from 5ff7866 to 83e9f5a Compare April 1, 2024 00:22
@rhatdan
Copy link
Member

rhatdan commented Apr 1, 2024

LGTM

@rhatdan rhatdan merged commit cf856ed into containers:main Apr 1, 2024
4 checks passed
@lmilbaum lmilbaum deleted the chatbot branch April 1, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford MichaelClifford is a code owner

@sallyom sallyom Awaiting requested review from sallyom sallyom is a code owner

Assignees

@lmilbaum lmilbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmilbaum @rhatdan