Embed workload bootable containers #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sallyom
force-pushed
the
embed-workload-bootable-containers
branch
3 times, most recently
from
6fc8d33 to
5ae8605
Compare
Signed-off-by: sallyom <[email protected]>
sallyom
force-pushed
the
embed-workload-bootable-containers
branch
from
5ae8605 to
84c3b77
Compare
|
Can you just move You must be a better typist then me. |
rhatdan
reviewed
Mar 29, 2024
| # podman build --build-arg "sshpubkey=$(cat ~/.ssh/mykey.pub)" -t quay.io/exampleos/example-image . | ||
| #Substitute YOUR public key for the below-private key holder for the following public key will have root access | ||
| ARG sshpubkey | ||
| ARG model-server-image=quay.io/redhat-et/locallm-model-service:latest |
There was a problem hiding this comment.
We should not set this default to be red hat specific.
rhatdan
reviewed
Mar 29, 2024
| RUN dnf install -y vim && dnf clean all | ||
|
|
||
| # Code-generation application | ||
| COPY quadlet/chatbot.kube.example /usr/share/containers/systemd/chatbot.kube |
There was a problem hiding this comment.
Why is this one called an example where the others are not? Source file should be chatbot.kube.
rhatdan
reviewed
Mar 29, 2024
| # pre-load workload images | ||
| # Comment the pull commands to keep bootc image smaller. | ||
| # With above quadlet .image file, these will be pulled on boot if not pre-loaded here | ||
| RUN podman pull quay.io/redhat-et/locallm-mistral-7b-gguf:latest |
There was a problem hiding this comment.
These should all be BUILD_ARGS and should not be default to redhat site. We could grab default quay.ai/ai-lab/ which would be a much better default.
rhatdan
reviewed
Mar 29, 2024
| # to switch to aarch64 platform, pass --platform linux/arm64 | ||
| podman build --build-arg "sshpubkey=$(cat ~/.ssh/id_rsa.pub)" \ | ||
| --cap-add SYS_ADMIN \ | ||
| --platform linux/amd64 \ |
rhatdan
reviewed
Mar 29, 2024
|
|
||
| ```bash | ||
| cp chatbot.yaml /usr/share/containers/systemd/chatbot.yaml | ||
| cp chatbot.kube.example /usr/share/containers/chatbot.kube |
|
Ok I am going to merge and then open a PR with my suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the README update PR #118
It also adds the first example for adding bootable images examples.
@rhatdan the first example I added is the generic
chatbotexample, since with this @lmilbaum can envision a test for the ai-app in a bootable image now (because the chatbot tests are in place)I'll add the summarizer example next.