Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace playground with model_servers #101

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

MichaelClifford
Copy link
Collaborator

Partially Address #89 (as this is a large change, planning on breaking it up into a couple of PRs)

  • Moves all files from playground/ into model_servers/llamacpp_python/
  • Updated ai-lab.yamls to point to the new file locations.

@rhatdan
Copy link
Member

rhatdan commented Mar 27, 2024

LGTM
But you need to sign your commits.

Copy link
Collaborator

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelClifford
Copy link
Collaborator Author

Thanks @lstocchi added.

Signed-off-by: Michael Clifford <[email protected]>
contextdir: ../playground
containerfile: Containerfile
contextdir: ../model_servers/llamacpp_python
containerfile: ../model_servers/llamacpp_python/base/Containerfile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice before but i think that the containerfile should be containerfile: ./base/Containerfile

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to all ai-lab files

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, was was actually not sure. It will start from the contextDir?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

contextdir: ../playground
containerfile: Containerfile
contextdir: ../model_servers/llamacpp_python
containerfile: ./model_servers/llamacpp_python/base/Containerfile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be ./base/Containerfile, right?

Signed-off-by: Michael Clifford <[email protected]>
Copy link
Collaborator

@sallyom sallyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sallyom sallyom merged commit 0055a48 into containers:main Mar 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants