ilab-wrapper: remove outdated comment

The comment is no longer relevant since we changed the way we pass environment variables to the container. Signed-off-by: Omer Tuchfeld <[email protected]>
containers · Aug 21, 2024 · cf8d5fa · cf8d5fa
1 parent 954071b
commit cf8d5fa
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/training/ilab-wrapper/ilab b/training/ilab-wrapper/ilab
@@ -135,8 +135,6 @@ PODMAN_COMMAND=("sudo" "--preserve-env=$PRESERVE_ENV" "podman" "run" "--rm" "-it
     "--pids-limit" "-1"
     "-v" "$HOME:$HOME"
     "${ADDITIONAL_MOUNT_OPTIONS[@]}"
-    # This is intentionally NOT using "--env" "HOME" because we want the HOME
-    # of the current shell and not the HOME set by sudo
     "--env" "VLLM_LOGGING_LEVEL"
     "--env" "HOME"
     "--env" "NCCL_DEBUG"

diff --git a/training/nvidia-bootc/duplicated/ilab-wrapper/ilab b/training/nvidia-bootc/duplicated/ilab-wrapper/ilab
@@ -135,8 +135,6 @@ PODMAN_COMMAND=("sudo" "--preserve-env=$PRESERVE_ENV" "podman" "run" "--rm" "-it
     "--pids-limit" "-1"
     "-v" "$HOME:$HOME"
     "${ADDITIONAL_MOUNT_OPTIONS[@]}"
-    # This is intentionally NOT using "--env" "HOME" because we want the HOME
-    # of the current shell and not the HOME set by sudo
     "--env" "VLLM_LOGGING_LEVEL"
     "--env" "HOME"
     "--env" "NCCL_DEBUG"