Skip to content

Commit

Permalink
Switch PROVIDER name to HARDWARE
Browse files Browse the repository at this point in the history
This better reflects its role.

Signed-off-by: Ralph Bean <[email protected]>
  • Loading branch information
ralphbean committed Jul 12, 2024
1 parent 56ba565 commit cf0b33e
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions training/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ nvidia: instruct-nvidia

.PHONY: amd-bootc-models nvidia-bootc-models intel-bootc-models
amd-models: amd
$(MAKE) PROVIDER=amd -C model bootc-models
$(MAKE) HARDWARE=amd -C model bootc-models
nvidia-models: nvidia
$(MAKE) PROVIDER=nvidia -C model bootc-models
$(MAKE) HARDWARE=nvidia -C model bootc-models
intel-models: intel
$(MAKE) PROVIDER=intel -C model bootc-models
$(MAKE) HARDWARE=intel -C model bootc-models

.PHONY: bootc-models
bootc-models:
Expand Down
4 changes: 2 additions & 2 deletions training/amd-bootc/Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
PROVIDER ?= amd
IMAGE_NAME ?= $(PROVIDER)-bootc
HARDWARE ?= amd
IMAGE_NAME ?= $(HARDWARE)-bootc

include ../common/Makefile.common

Expand Down
6 changes: 3 additions & 3 deletions training/common/Makefile.common
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM ?=
PROVIDER ?=
HARDWARE ?=

REGISTRY ?= quay.io
REGISTRY_ORG ?= ai-lab
IMAGE_NAME ?= $(PROVIDER)-bootc
IMAGE_NAME ?= $(HARDWARE)-bootc
IMAGE_TAG ?= latest
BOOTC_IMAGE ?= ${REGISTRY}/${REGISTRY_ORG}/${IMAGE_NAME}:${IMAGE_TAG}
BOOTC_MODELS_IMAGE ?= ${REGISTRY}/${REGISTRY_ORG}/${IMAGE_NAME}-models:${IMAGE_TAG}
Expand Down Expand Up @@ -35,7 +35,7 @@ ARCH ?=
DRIVER_VERSION ?=
KERNEL_VERSION ?=

INSTRUCTLAB_IMAGE = $(REGISTRY)/$(REGISTRY_ORG)/instructlab-$(PROVIDER):$(IMAGE_TAG)
INSTRUCTLAB_IMAGE = $(REGISTRY)/$(REGISTRY_ORG)/instructlab-$(HARDWARE):$(IMAGE_TAG)
WRAPPER = $(CURDIR)/../ilab-wrapper/ilab
QLORA_WRAPPER = $(CURDIR)/../ilab-wrapper/ilab-qlora
TRAIN_WRAPPER = $(CURDIR)/../ilab-wrapper/ilab-training-launcher
Expand Down
4 changes: 2 additions & 2 deletions training/nvidia-bootc/Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
PROVIDER ?= nvidia
IMAGE_NAME ?= $(PROVIDER)-bootc
HARDWARE ?= nvidia
IMAGE_NAME ?= $(HARDWARE)-bootc

CUDA_VERSION ?=
OS_VERSION_MAJOR ?=
Expand Down

0 comments on commit cf0b33e

Please sign in to comment.