properly name object detection client job + moving pip install to tests

Signed-off-by: greg pereira <[email protected]>
containers · May 11, 2024 · 943a6cb · 943a6cb
1 parent aea3a6e
commit 943a6cb
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/object_detection.yaml b/.github/workflows/object_detection.yaml
@@ -24,7 +24,7 @@ env:
   IMAGE_NAME: object_detection_client
 
 jobs:
-  chatbot-build-and-push:
+  object-detection-client-build-and-push:
     if: "!contains(github.event.pull_request.labels.*.name, 'hold-tests')"
     runs-on: ubuntu-22.04
     permissions:

diff --git a/model_servers/object_detection_python/Makefile b/model_servers/object_detection_python/Makefile
@@ -28,5 +28,6 @@ download-model-facebook-detr-resnet-101:
 
 .PHONY: test
 test:
+	pip install -r ../../convert_models/requirements.txt
 	cp -r ../../models/facebook ./
 	REGISTRY=$(REGISTRY) MODEL_NAME=$(MODEL_NAME) MODELS_DIR=$(MODELS_DIR) IMAGE_NAME=$(IMAGE_NAME) PORT=$(PORT) pytest -s -vvv
diff --git a/models/Makefile b/models/Makefile
@@ -39,7 +39,6 @@ download-model-mistral-code:
 
 .PHONY: download-model-facebook-detr-resnet-101
 download-model-facebook-detr-resnet-101:
-	pip install -r ../convert_models/requirements.txt
 	cd ../convert_models/ && \
 	python3 download_huggingface.py -m facebook/detr-resnet-101
 	cp -r ../convert_models/converted_models/facebook ./