Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parquet version #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bluesheeptoken
Copy link

To add zstd-jni and support zstd-jni compression easily in connectors. cf: apache/parquet-java#793

Problem

Currently, to access the zstd compression. We need to add the Hadoop native library, cf: confluentinc/kafka-connect-storage-cloud#570 (comment)

We could add the zstd-jni package by updating parquet version to ease the use of zstd codec.

Solution

Update parquet version

Tests

No tests have been made.
How could I test it? I have seen that in implementations such as Kafka-connect-storage-cloud, this lib is "provided" and all its transitive dependencies. How can I use this PR to build a new Docker image that could be used for local tests?

Is there a way to add unit tests?

I would be happy to help, but kinda lost on this repo

To add zstd-jni and support zstd-jni compression easily in connectors.
cf: apache/parquet-java#793
@bluesheeptoken bluesheeptoken requested a review from a team as a code owner May 4, 2023 14:54
@BDeus
Copy link
Contributor

BDeus commented May 24, 2023

Nice add to not depend on hadoop library.

However, there was a revert on parquet 1.12.3 here
Maybe need to test that the Error not happen again.

FYI there is a new version of parquet 1.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants