Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added int64 customer formatter #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kerdosa
Copy link

@kerdosa kerdosa commented Nov 18, 2021

Problem

The avro int64 type with logicalType timestamp-millis becomes Date class in Java. Current FieldPartitioner cast it to Number class which throws exception.

Solution

If int64 type is Date object, use the SimpleDateFormat to convert the Date to string.

Related Issues

[ch124048]

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@kerdosa kerdosa requested a review from a team as a code owner November 18, 2021 21:07
@kpatelatwork
Copy link
Member

kpatelatwork commented Nov 18, 2021

@kerdosa Thanks for the contribution, would you mind adding a unit and integration test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants