Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend config of RecordTimestampExtractor with date-time format pattern #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gadomsky
Copy link

Problem

Partitioning by String field is possible only if this field contains data in only one specific format. There is no easy way to override RecordFieldTimestampExtractor with custom datetime formatter.

Solution

This PR introduceses new configuration field with format pattern.
Default value of this new configuration is empty String, cause there is no coressponding pattern to DatetimeFormatter beeing used currently - it is only possible to set this programmticaly.

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@gadomsky gadomsky requested a review from a team as a code owner September 13, 2021 13:00
@OneCricketeer
Copy link

You should be able to use an SMT to convert the timestamp before it even reaches the partitioner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants