-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the topic name configurable in storage paths #127
base: master
Are you sure you want to change the base?
Conversation
@confluentinc It looks like @hariprasad-k just signed our Contributor License Agreement. 👍 Always at your service, clabot |
Fixed #126 |
Question: What happens when you have Then all files in the directory will be of multiple topics? |
@@ -101,6 +101,20 @@ | |||
public static final String TIMESTAMP_FIELD_NAME_DEFAULT = "timestamp"; | |||
public static final String TIMESTAMP_FIELD_NAME_DISPLAY = "Record Field for Timestamp Extractor"; | |||
|
|||
public static final String TIMESTAMP_SCALING_FACTOR_CONFIG = "timestamp.scaling.factor"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you break this out as a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OneCricketeer Sure, I will break into separate PR.
@OneCricketeer Yes, all files of multiple topics will be in the same directory in this case. But, this behavior will only happen if you use |
@OneCricketeer This PR does not have any changes related to Timestamp scaling factor anymore, which is covered by #160 Can you please review this changes ? |
I'm not a Confluent employee, so my reviews don't do anything |
…used in partitioning by configuration into another PR
Thanks @hariprasad-k for the contribution! This change will add flexibility to our connectors that use storage common to optionally exclude the topic name from the path (seems to be a popular request confluentinc/kafka-connect-hdfs#544). I'd like to get second view from @levzem before proceeding. |
Would be very much interested in having this feature integrated. The topic name being forcefully appended to the path limits us severely when sinking to already-established directory structures. |
Improvements to provide ability to exclude topic name in partition by configuration