-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCD-481 : Adding reconnection logic added for HDFS2 sink connector #531
base: 10.0.x
Are you sure you want to change the base?
Conversation
It looks like @SanchayGupta1197 hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
conf.getHadoopConfiguration() | ||
); | ||
fileSystem.delete(path, true); | ||
} catch (IOException ex) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we log this error message as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added the exception to the log below.
URI.create(conf.getUrl()), | ||
conf.getHadoopConfiguration() | ||
); | ||
fileSystem.delete(path, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too familiar with HDFS. Why are we deleting the file for ORC here? Why is schema=null
not enough like with AVRO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current version of org.apache.hadoop.hive.ql.io.orc.OrcFile.WriterOptions
does not supports file overwriting therefore deleting tmp file wheneverAlreadyBeingCreatedException
is thrown.
|
Problem
The connector was failing for
Avro
andORC
format when the connection to the cluster was interrupted.Solution
Fix for Avro
null
in order to invalidate the current temp file.AvroRuntimeException
was caught and thrown as aConnectException
.Fix for ORC
null
in order to invalidate the current temp file.AlreadyBeingCreatedException
was handled by deleting the temp file from the cluster.Test Strategy
Testing done:
Issues/Limitation
connect-runtime
and HDFSminicluster
.