Recover the offset from HDFS, even if topic name is not present in storage path #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @hariprasad-k just signed our Contributor License Agreement. 👍 Always at your service, clabot |
|
Fixes #515 |
| @@ -101,7 +102,12 @@ public static String committedFileName( | |||
| } | |||
|
|
|||
| public static String topicDirectory(String url, String topicsDir, String topic) { | |||
| return url + "/" + topicsDir + "/" + topic; | |||
| boolean topicInPath = Boolean.valueOf(StorageCommonConfig.PATH_INCLUDE_TOPICNAME_CONFIG); | |||
There was a problem hiding this comment.
This will always be false since you're parsing the config string, not looking up the value in the config
|
Could you please add unit tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#346 Problem
Exactly-once semantics should also work without topic name included in the path.
Solution
The function that recover offsets from file names will use the correct path by taking into account a new configuration flag
path_include_topicnameintroduced with confluentinc/kafka-connect-storage-common#126.Further, the backward compatibility of appending the topic name is retained by default value
trueforpath_include_topicname.Does this solution apply anywhere else?
If yes, where?
This change is necessary to retain EOS semantics to support flexible storage partitioning scheme as proposed here: confluentinc/kafka-connect-storage-common#126
Test Strategy
Testing done:
Release Plan