Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for max retry backoff time (#750) #756

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pricelessjunk
Copy link

@pricelessjunk pricelessjunk commented Mar 2, 2024

Problem

The current max retry back off time is set at a constant of 24 hours. This duration is too long to be practical.

Solution

Making the duration configurable by creating a new property max.retry.duration.ms. This property has the following features

  • It has a default value of 24 hours (just like before).
  • It must have a value greater than the value of retry.backoff.ms (initial backoff time). If a smaller or equal value is set, a warning message is thrown and the default value is selected instead.
Does this solution apply anywhere else?
  • yes
  • no

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@pricelessjunk pricelessjunk requested a review from a team as a code owner March 2, 2024 08:24
Copy link

cla-assistant bot commented Mar 2, 2024

CLA assistant check
All committers have signed the CLA.

@pricelessjunk pricelessjunk force-pushed the new_max_retry_backoff_time_property branch 5 times, most recently from f0c4640 to f96de85 Compare March 2, 2024 11:19
@pricelessjunk pricelessjunk changed the title Support for max retry backoff time #750 Support for max retry backoff time (#750) Mar 3, 2024
@pricelessjunk pricelessjunk force-pushed the new_max_retry_backoff_time_property branch from f96de85 to 0b06a39 Compare March 3, 2024 10:13
@pricelessjunk
Copy link
Author

@sp-gupta Hello. Could you please take a look at this code. Thanks.

@tv2-andreasBerre
Copy link

Any way to get this PR approved? It fixes a feature which quite often causes problems..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants