Update Description to include Elastic 8.0 info #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sp-gupta
force-pushed
the
updateDescription
branch
from
06147de to
12d948e
Compare
snehashisp
reviewed
Feb 14, 2023
sp-gupta
force-pushed
the
updateDescription
branch
from
12d948e to
7fdc0f2
Compare
tobydrake7
reviewed
Feb 14, 2023
pom.xml
Outdated
| @@ -150,7 +150,7 @@ | |||
| <title>Kafka Connect Elasticsearch</title> | |||
| <documentationUrl>https://docs.confluent.io/${project.version}/connect/connect-elasticsearch/docs/index.html</documentationUrl> | |||
| <description> | |||
| The Elasticsearch connector allows moving data from Kafka to Elasticsearch 2.x, 5.x, 6.x, and 7.x. It writes data from a topic in Kafka to an index in Elasticsearch and all data for a topic have the same type. | |||
| The Elasticsearch connector allows moving data from Kafka to Elasticsearch 2.x, 5.x, 6.x, 7.x, and 8.x. The support for Elasticsearch depends on which version the connector is running. Newer versions of the connector may not support all previous versions of ES. ES 8.x was introduced from version 14.0.0. It writes data from a topic in Kafka to an index in Elasticsearch and all data for a topic have the same type. | |||
There was a problem hiding this comment.
Suggested change
| The Elasticsearch connector allows moving data from Kafka to Elasticsearch 2.x, 5.x, 6.x, 7.x, and 8.x. The support for Elasticsearch depends on which version the connector is running. Newer versions of the connector may not support all previous versions of ES. ES 8.x was introduced from version 14.0.0. It writes data from a topic in Kafka to an index in Elasticsearch and all data for a topic have the same type. | |
| The Elasticsearch connector moves data from Kafka to Elasticsearch 2.x, 5.x, 6.x, 7.x, and 8.x. Elasticsearch version support depends the connector version. Newer connector versions may not support older versions of Elasticsearch. Elasticsearch 8.x support was introduced with connector version 14.0.0. This connector version writes data from a topic in Kafka to an index in Elasticsearch, and all data for the topic has the same type. |
There was a problem hiding this comment.
@sp-gupta some minor suggestions for rewording. Please modify if I've changed your technical intent.
There was a problem hiding this comment.
@sp-gupta you may want to expand on this part add data for a topic have the same type does this mean that the connector keeps all datatypes from the topic consistent when it moves it to Elasticsearch? might be good to add a little more to this or add an extra explanatory sentence about this 👍
There was a problem hiding this comment.
@tobydrake7 Thanks, I have updated it. Please review.
sp-gupta
force-pushed
the
updateDescription
branch
from
7fdc0f2 to
9051578
Compare
|
|
|
@sp-gupta not sure the status of this one. I approved a while back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Release Plan