Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix cargo warnings on missing default-features #475

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Aug 22, 2024

Builds trigger the following warnings that are easy to fix:

warning: /home/runner/work/trustee/trustee/deps/verifier/Cargo.toml: default-features is ignored for tokio, since default-features was not specified for workspace.dependencies.tokio, this could become a hard error in the future

and

warning: /home/runner/work/trustee/trustee/tools/kbs-client/Cargo.toml: default-features is ignored for reqwest, since default-features was not specified for workspace.dependencies.reqwest, this could become a hard error in the future

Builds trigger the following warnings that are easy to fix:

warning: /home/runner/work/trustee/trustee/deps/verifier/Cargo.toml: `default-features`
is ignored for tokio, since `default-features` was not specified for
`workspace.dependencies.tokio`, this could become a hard error in the future

and

warning: /home/runner/work/trustee/trustee/tools/kbs-client/Cargo.toml: `default-features`
is ignored for reqwest, since `default-features` was not specified for
`workspace.dependencies.reqwest`, this could become a hard error in the future

Signed-off-by: Mikko Ylinen <[email protected]>
@mythi mythi requested a review from sameo as a code owner August 22, 2024 13:11
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Xynnn007 Xynnn007 merged commit c7086a7 into confidential-containers:main Aug 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants