ibmse: use hash rather than hex for initdata digest in claims #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the initdata hash value directly rather than it's hex in claims Signed-off-by: Qi Feng Huo <[email protected]>
mkulke
approved these changes
Aug 12, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the initdata hash value directly rather than it's hex in claims.
It's more reasonable to use the fixed length hash value
initdata.digestrather than its HEX in claims because it's more straight forward for user to set the hash value in attestation policy.Related PR:
confidential-containers/guest-components#616
confidential-containers/cloud-api-adaptor#1991