Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: refactor docker folder structure #427

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

pawelpros
Copy link
Contributor

@pawelpros pawelpros commented Jun 21, 2024

  • Refactored AS docker placement
  • Refactored RVPS docker placement
  • Refactored KBS docker placement

This change improves Dockerfile readability as current approach (format: Dockerfile.[name]) is not compatible with code inspection in IDEs which can lead to errors.

@pawelpros
Copy link
Contributor Author

This PR will be ready after merge: #410

@Xynnn007
Copy link
Member

btw #410 has been merged

@fitzthum
Copy link
Member

@pawelpros I think we're ready for this after a rebase

@pawelpros pawelpros marked this pull request as ready for review July 8, 2024 13:07
@pawelpros pawelpros requested a review from sameo as a code owner July 8, 2024 13:07
- Refactored AS/KBS/rvps docker placement

This change improves Dockerfile readability as current approach (format: Dockerfile.[name]) is not compatible with code inspection in IDEs which can lead to errors.

Signed-off-by: Pawel Proskurnicki <[email protected]>
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xynnn007 Xynnn007 merged commit 202deb9 into confidential-containers:main Jul 8, 2024
16 checks passed
@pawelpros pawelpros deleted the docker-refactor branch July 9, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants