td-shim: remove the use of Vec in e820
#700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaojiaqi7
force-pushed
the
0511/remove_vectors_in_e820
branch
from
5b49c49 to
4a60eb0
Compare
jyao1
reviewed
May 20, 2024
td-shim/src/bin/td-shim/e820.rs
Outdated
| } | ||
|
|
||
| // Move all entries after the index back one position | ||
| for idx in (index + 1..self.num_entries + 1).rev() { |
There was a problem hiding this comment.
what if the index > self.num_entries?
what if the index == self.num_entries?
jyao1
reviewed
May 20, 2024
td-shim/src/bin/td-shim/e820.rs
Outdated
| } | ||
|
|
||
| // Move all entries after the index forward one position | ||
| for idx in index + 1..self.num_entries { |
There was a problem hiding this comment.
what if the index > self.num_entries?
what if the index == self.num_entries?
Reducing the use of heap can improve the functional safety. For e820 implementation, use an fixed `MAX_E820_ENTRY` size array to replace the vector. Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
0511/remove_vectors_in_e820
branch
from
4a60eb0 to
387cc8b
Compare
jyao1
reviewed
May 22, 2024
| } | ||
|
|
||
| fn remove_entry(&mut self, index: usize) -> Result<(), E820Error> { | ||
| if index >= self.num_entries { |
There was a problem hiding this comment.
if self.num_entries == 0, the index >= self.num_entries will always be true, then it will return error
jyao1
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reducing the use of heap can improve the functional safety. For e820 implementation, use an fixed
MAX_E820_ENTRYsize array to replace the vector.Relate issue: #685