Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Always run e2e testing #447

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

ldoktor
Copy link
Contributor

@ldoktor ldoktor commented Sep 19, 2024

the "e2e-pr / operator tests" is always required so we have to run it even though it does not make much sense.

This should help with #444

the "e2e-pr / operator tests" is always required so we have to run it
even though it does not make much sense.

Signed-off-by: Lukáš Doktor <[email protected]>
@ldoktor ldoktor requested a review from a team as a code owner September 19, 2024 14:41
@ldoktor
Copy link
Contributor Author

ldoktor commented Sep 19, 2024

Note that alternative would be to use:

    # Step 1: Checkout the PR code
    - name: Checkout code
      uses: actions/checkout@v3

    # Step 2: Get list of changed files and set 'docs_only' variable
    - name: Determine if only docs/** files changed
      id: set_docs_only
      run: |
        # Get the list of changed files in the PR
        git fetch origin main
        changed_files=$(git diff --name-only origin/main...HEAD)

        echo "Changed files:"
        echo "$changed_files"

        # Check if all files are in the docs/ folder
        docs_only=true
        for file in $changed_files; do
          if [[ ! $file == docs/* ]]; then
            docs_only=false
            break
          fi
        done

        echo "docs_only=$docs_only" >> $GITHUB_ENV

    - name: Operator tests (kata-qemu, ${{ matrix.os }})
      if: ${{ env.docs_only == 'true' }}
      uses: ./.github/workflows/skip_e2e.yaml

and add the skip_e2e test that would only report pass. But IMO it's unnecessary too complex, what do you think?

@stevenhorsman
Copy link
Member

add the skip_e2e test that would only report pass. But IMO it's unnecessary too complex, what do you think?

I think it's worth discussing an option like this more, but for now just re-enabling the ci to unblock us is probably the best path

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@BbolroC BbolroC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ldoktor !

@wainersm wainersm merged commit 5794e79 into confidential-containers:main Sep 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants