Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to k8s.io v1.30, Go 1.22.0, and controller-runtime v0.18.0 #426

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Aug 27, 2024

No description provided.

@mythi mythi changed the title chore(deps): bumpto k8s.io v1.30, Go 1.22.0, and controller-runtime … bump to k8s.io v1.30, Go 1.22.0, and controller-runtime v0.18.0 Aug 27, 2024
@mythi
Copy link
Contributor Author

mythi commented Aug 28, 2024

The context for this is that #425 will start complaining about Go version syntax in go.mod. However, that is not the only reason for the upgrade. we are greatly outdated with the dependencies

@mythi mythi marked this pull request as ready for review August 28, 2024 04:55
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @mythi. This has been long due.

Makefile Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
Copy link
Member

@BbolroC BbolroC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the comment below is addressed, thanks @mythi !

OK. I will update some of these after #425 is merged

@mythi mythi force-pushed the go-mod-update-2 branch 2 times, most recently from 8f827f2 to 9e4c650 Compare August 29, 2024 12:06
@mythi mythi marked this pull request as draft August 29, 2024 13:33
@mythi
Copy link
Contributor Author

mythi commented Aug 29, 2024

moved to draft since I got myself into a rabbit hole with the k8s stuff...

@mythi mythi force-pushed the go-mod-update-2 branch 4 times, most recently from a1c77ba to e21f3ec Compare August 30, 2024 13:16
@mythi mythi marked this pull request as ready for review August 30, 2024 13:17
setup-envtest seems to support s390x also:
$ setup-envtest list --os linux --arch s390x
(available)  v1.31.0  linux/s390x
(available)  v1.30.3  linux/s390x
(available)  v1.30.2  linux/s390x
(available)  v1.30.0  linux/s390x
(available)  v1.29.5  linux/s390x
(available)  v1.29.4  linux/s390x
(available)  v1.29.3  linux/s390x
(available)  v1.29.1  linux/s390x
(available)  v1.29.0  linux/s390x
(available)  v1.28.3  linux/s390x
(available)  v1.28.0  linux/s390x
(available)  v1.27.1  linux/s390x
(available)  v1.26.1  linux/s390x
(available)  v1.26.0  linux/s390x
(available)  v1.25.0  linux/s390x
(available)  v1.24.2  linux/s390x
(available)  v1.24.1  linux/s390x
(available)  v1.23.5  linux/s390x

Signed-off-by: Mikko Ylinen <[email protected]>
At the same time, update docs a bit to not mention any specific
component versions where they are no longer relevant.

Signed-off-by: Mikko Ylinen <[email protected]>
@mythi
Copy link
Contributor Author

mythi commented Sep 2, 2024

@BbolroC @bpradipt mind taking another look, I pushed some additional commits

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mythi!

@fidencio fidencio merged commit 71c4dfc into confidential-containers:main Sep 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants