Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: update go-urn #405

Merged
merged 1 commit into from
Aug 5, 2024
Merged

go.mod: update go-urn #405

merged 1 commit into from
Aug 5, 2024

Conversation

fitzthum
Copy link
Member

@fitzthum fitzthum commented Aug 2, 2024

This should resolve our license failure.

Go-urn included the wrong license string in a previous release, but it has been removed.

@fitzthum
go.mod: update go-urn
3132fa4 
This should resolve our license failure.

Go-urn included the wrong license string in a previous
release, but it has been removed.

Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
fidencio
fidencio approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @fitzthum!

bpradipt
bpradipt approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

ldoktor
ldoktor approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one of the CI jobs failed with the occasional-to-be-seen failure where uninstall won't install. I don't think it's related to this change.

@ldoktor
Copy link
Contributor

ldoktor commented Aug 5, 2024

Well it failed in the same manner, either the s390x machine is misbehaving or there might actually be a problem with that version on it? @BbolroC any ideas? https://github.com/confidential-containers/operator/actions/runs/10236858387/job/28332541893?pr=405

@BbolroC
Copy link
Member

BbolroC commented Aug 5, 2024 •
edited
Loading

Well it failed in the same manner, either the s390x machine is misbehaving or there might actually be a problem with that version on it? @BbolroC any ideas? https://github.com/confidential-containers/operator/actions/runs/10236858387/job/28332541893?pr=405

Let me rerun the test and look into it. Thanks.

The s390x runner is being busy with handling CI jobs for other repos. I will take some time to start the investigation.

@BbolroC BbolroC mentioned this pull request Aug 5, 2024
Merged
@BbolroC
Copy link
Member

BbolroC commented Aug 5, 2024

It turns out a golang version on the runner at the time of Ci failure (1.21.x) has an issue. The CI job went green with the latest golang (1.22.5). https://github.com/confidential-containers/operator/actions/runs/10246488905/job/28343684076?pr=406

But there was a dependency issue on controller-gen with the latest golang. We can merge #406 first and rebase/merge this one. Thanks.

@BbolroC BbolroC merged commit 2e6a90f into confidential-containers:main Aug 5, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpradipt bpradipt bpradipt approved these changes

@ldoktor ldoktor ldoktor approved these changes

@fidencio fidencio fidencio approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fitzthum @ldoktor @BbolroC @fidencio @bpradipt