Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests:e2e: Install kustomize from the Go source code #404

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

GabyCT
Copy link
Contributor

@GabyCT GabyCT commented Aug 1, 2024

This PR installs the kustomize CLI from source in order to avoid the random failures due to the Github Actions rate limitations.

This PR installs the kustomize CLI from source in order to avoid
the random failures due to the Github Actions rate limitations.

Signed-off-by: Gabriela Cervantes <[email protected]>
@GabyCT
Copy link
Contributor Author

GabyCT commented Aug 1, 2024

@ldoktor please check this PR, I've test it locally and seems to be working

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's see how it behaves in the CI.

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @GabyCT!

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works well on my computer, works well in the currently working CI, lets get this in.

@ldoktor ldoktor merged commit b63d28e into confidential-containers:main Aug 5, 2024
9 of 14 checks passed
@ldoktor ldoktor mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants