Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.e2e: Install kustomize from a release tarball #402

Closed
wants to merge 1 commit into from

Conversation

GabyCT
Copy link
Contributor

@GabyCT GabyCT commented Jul 29, 2024

This PR changes the installation of kustomize by using the release tarball in order to avoid being hit by issues of the github rate limitation.

This PR changes the installation of kustomize by using the release
tarball in order to avoid being hit by issues of the github
rate limitation.

Signed-off-by: Gabriela Cervantes <[email protected]>
@GabyCT
Copy link
Contributor Author

GabyCT commented Jul 29, 2024

@ldoktor this is an alternative that I am proposing to the github issue but please let me know your comments

tarball="kustomize_${version}_linux_${arch}.tar.gz"
curl -Lf -o "$tarball" "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2F${version}/kustomize_${version}_linux_${arch}.tar.gz"
tar -xvzf "${tarball}" -C /usr/local/bin
command -v kustomize >/dev/null 2>&1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea although it changes the behaviour from install latest master to install latest release. If we are changing the behaviour I'd probably go with pinned known-to-work version rather than potentially unstable query for the latest release. Alternatively we could first install go and then use GOBIN=$(pwd)/ GO111MODULE=on go install sigs.k8s.io/kustomize/kustomize/v5@latest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldoktor ok let me try it by using your proposal...I will change the script

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw the GOBIN should be /usr/local/bin, the previous command was taken from kustomize documentation ;-)

@GabyCT GabyCT closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants