Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Revert v0.9.0 release-specfic changes back to dev values #401

Merged

Conversation

niteeshkd
Copy link

This reverts the changes done in two commits (related to the kata payloads and enclave-cc payloads) with the PR #397 .

Niteesh Dubey added 2 commits July 26, 2024 15:25
This reverts commit 4e585d7.

Signed-off-by: Niteesh Dubey <[email protected]>
@ldoktor
Copy link
Contributor

ldoktor commented Jul 27, 2024

Looks good, how about the d51c1e4 shouldn't it be tagged to the next alpha to keep the release-required changes together?

@niteeshkd
Copy link
Author

Looks good, how about the d51c1e4 shouldn't it be tagged to the next alpha to keep the release-required changes together?

I am not sure whether d51c1e4 should be tagged to next alpha ( as it might mean that we already know the requirements for that alpha release) but may be we could tag it to latest (similar to tags for others).
@fitzthum - any suggestion ?

@fitzthum
Copy link
Member

@ldoktor @niteeshkd

There is no alpha release planned for v0.10.0.

We haven't updated this tag between releases in the past. There might be a case for something like v0.9.0+, but I would probably just keep it as it is.

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @niteeshkd!

Copy link
Member

@ryansavino ryansavino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fidencio fidencio merged commit 019b640 into confidential-containers:main Aug 4, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants