Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix misspelling on peer pods test document #399

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

GabyCT
Copy link
Contributor

@GabyCT GabyCT commented Jul 24, 2024

This PR fixes a misspelling on the peer pods test document.

This PR fixes a misspelling on the peer pods test document.

Signed-off-by: Gabriela Cervantes <[email protected]>
Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. A question to other reviewers, is it really necessary to run functional CI on this PR? We don't have the protection here and in this case I'd suggest skipping it...

@bpradipt
Copy link
Member

lgtm. A question to other reviewers, is it really necessary to run functional CI on this PR? We don't have the protection here and in this case I'd suggest skipping it...

It's not needed.. However I think some workflows will automatically run.

Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bpradipt
Copy link
Member

However I don't know if there is a way to override the required tests via a label. May be @wainersm @stevenhorsman or @fidencio might know.

@ldoktor
Copy link
Contributor

ldoktor commented Jul 25, 2024

However I don't know if there is a way to override the required tests via a label. May be @wainersm @stevenhorsman or @fidencio might know.

Ahh we do have the required set for them so no, they have to run... Anyway I tried :-)

@fidencio
Copy link
Member

fidencio commented Aug 4, 2024

I'm bypassing CI and pushing this one, as it doesn't make sense to run CI on this case (and it seems jobs wouldn't even be triggered).

@fidencio fidencio merged commit 5e4df70 into confidential-containers:main Aug 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants