fix: add support for imagePullPolicy for installer daemonsets (#395) #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodor-pripoae
force-pushed
the
image-pull-policy
branch
from
bfab94e to
9e25c3a
Compare
fidencio
approved these changes
Aug 4, 2024
|
@stevenhorsman @fidencio would you be able to re-run the required tests for this PR? |
I've tried closing and re-opening, but it might need a rebase as the jobs have changes since then |
|
@teodor-pripoae would you be able to rebase the PR? Sorry for the delay :-( |
|
Otoh, may be rebase is not needed. All required tests are passing and this can be merged.. |
bpradipt
merged commit 40240ab
into
confidential-containers:main
25 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for ImagePullPolicy which is present in the CRD but not actually used (default Always).