Makefile: scripts: Add build args for proxy when using docker build #385
Conversation
There was a problem hiding this comment.
The code LGTM, but one question about where the http_proxy and https_proxy values are set - is the expectation that these environment variables are set on the self-hosted runner independently of the operator workflow?
It looks like we get unbound variable errors when http_proxy isn't set, so I guess we need to make that behaviour safe too.
GabyCT
force-pushed
the
topic/fixdockerarg
branch
from
c8d6fac to
50a84cf
Compare
|
@stevenhorsman changes applied |
| @@ -143,9 +146,9 @@ run: manifests generate fmt vet ## Run a controller from your host. | |||
| docker-build: test ## Build docker image with the manager. | |||
| ifneq (, $(PEERPODS)) | |||
| @echo PEERPODS is enabled | |||
| docker build -t ${IMG} -f Dockerfile.peerpods . | |||
| docker build --build-arg http_proxy=$(http_proxy) --build-arg https_proxy=$(https_proxy) -t ${IMG} -f Dockerfile.peerpods . | |||
There was a problem hiding this comment.
is there a reason why this approach was chosen over the better alternative which just setting the ~/.docker/config.json?
There was a problem hiding this comment.
@mythi I have the proxies at the config but seems that when building the dockerfile is still failing without those arguments
There was a problem hiding this comment.
I don't prefer this approach. It'd be good to understand why the best option does not work
GabyCT
force-pushed
the
topic/fixdockerarg
branch
2 times, most recently
from
550c956 to
dec86b7
Compare
This PR adds build args for proxy when using docker build, this is specially needed when we are behind a proxy to avoid failures. Signed-off-by: Gabriela Cervantes <[email protected]>
|
@stevenhorsman now the CI for tdx is passing |
This PR adds build args for proxy when using docker build, this is specially needed when we are behind a proxy to avoid failures.