CI: Pin requests' version less than 2.32 #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BbolroC
changed the title
BbolroC
force-pushed
the
fix-docker-issue-on-runner
branch
from
12a9d15 to
dbc8478
Compare
BbolroC
changed the title
BbolroC
force-pushed
the
fix-docker-issue-on-runner
branch
from
dbc8478 to
c86b501
Compare
BbolroC
changed the title
The issue docker/docker-py#3113 seems to be resolved. The pinned version of requests (2.28.1) is no longer compatible with the current docker pip, resulting in errors like: "Error connecting: Error while fetching server API version: Not supported URL scheme http+docker" Initially, we attempted to allow pip to install requests according to its dependency tree. However, the issue persists on Ubuntu 22.04, and it appears to be related to docker/docker-py#3256. The best solution so far is to pin the version of the package to less than 2.32. Fixes: confidential-containers#381 Signed-off-by: Hyounggyu Choi <[email protected]>
BbolroC
force-pushed
the
fix-docker-issue-on-runner
branch
from
c86b501 to
5eaedb9
Compare
portersrc
approved these changes
May 23, 2024
wainersm
reviewed
May 23, 2024
| - name: Downgrade requests | ||
| shell: | | ||
| actual_version="$(pip3 show requests | grep Version | cut -d: -f2 | xargs)" | ||
| version_ge="$(echo -e "2.29.0\n$actual_version" | sort -V | head -1)" |
There was a problem hiding this comment.
The other day I was looking for this exact line and I couldn't find. This is a good way to compare semver numbers in bash. So long lovely code, so long!
wainersm
reviewed
May 23, 2024
| fi | ||
| name: | ||
| - docker | ||
| - requests<2.32 |
There was a problem hiding this comment.
And I didn't know we could specify '<', '>', ...., in this command. Cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue docker/docker-py#3113 seems to be resolved. The pinned version of requests (2.28.1) is no longer compatible with the current docker pip, resulting in errors like:
Initially, we attempted to allow pip to install requests according to its dependency tree.
However, the issue persists on Ubuntu 22.04, and it appears to be related to docker/docker-py#3256.
The best solution so far is to pin the version of the package to less than 2.32.
The change is verified at https://github.com/confidential-containers/operator/actions/runs/9204691086?pr=382
Fixes: #381
Signed-off-by: Hyounggyu Choi [email protected]