Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-reqs: Bump reqs-payload image #379

Merged
merged 1 commit into from
May 16, 2024
Merged

pre-reqs: Bump reqs-payload image #379

merged 1 commit into from
May 16, 2024

Conversation

stevenhorsman
Copy link
Member

  • After we updated to pick up nydus-snapshotter v0.3.13 in the pre-reqs image, start picking up this version.

fitzthum
fitzthum approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldoktor
ldoktor approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does cover all of the places although the commit message is a bit cryptical (maybe because I'm not native). Something like pre-reqs image had been recently updated to use nydus-snapshotter v0.3.13, use that version in our sample configs. would be IMO clearer, what do you think? (again, I'm not native)

@stevenhorsman
Copy link
Member Author

This does cover all of the places although the commit message is a bit cryptical (maybe because I'm not native). Something like pre-reqs image had been recently updated to use nydus-snapshotter v0.3.13, use that version in our sample configs. would be IMO clearer, what do you think? (again, I'm not native)

That's fair - Wainer recently accused my commit messages of sounding like they were AI generated, so I need to work on that!

@stevenhorsman
pre-reqs: Bump reqs-payload image
59fd9c1 
- The reqs-payload has recently been rebuilt to be updated to
use nydus-snapshotter v0.3.13, so we want to pick up that tag of
the image in our sample configs

Signed-off-by: stevenhorsman <[email protected]>
@stevenhorsman stevenhorsman force-pushed the bump-req-payload-for-nydus-0.3.13 branch from 3a5daf1 to 59fd9c1 Compare May 15, 2024 16:27
@stevenhorsman
Copy link
Member Author

This does cover all of the places although the commit message is a bit cryptical (maybe because I'm not native). Something like pre-reqs image had been recently updated to use nydus-snapshotter v0.3.13, use that version in our sample configs. would be IMO clearer, what do you think? (again, I'm not native)

@ldoktor - I hope this update is clearer? If not - let me know!

ldoktor
ldoktor approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you

@ldoktor ldoktor merged commit 5fa6bb5 into confidential-containers:main May 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzthum fitzthum fitzthum approved these changes

@ldoktor ldoktor ldoktor approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenhorsman @ldoktor @fitzthum