Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: remove ssh-demo #374

Merged
merged 1 commit into from
May 15, 2024

Conversation

fitzthum
Copy link
Member

@fitzthum fitzthum commented May 2, 2024

Following from #370

I think we'll need to cleanup a few things in the docs as well (see confidential-containers/confidential-containers#211)

The ssh-demo is out of date and no longer necessary.

Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always a joy seeing old unmaintained stuffs getting out. Thanks @fitzthum !

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, seems to cover all mentionings of ssh-demo here. Wainer, is your blog post updated, can we merge this?

@wainersm
Copy link
Member

Hi @ldoktor !

Yep, seems to cover all mentionings of ssh-demo here. Wainer, is your blog post updated, can we merge this?

On the blog post https://www.redhat.com/en/blog/how-use-confidential-containers-without-confidential-hardware luckily It points to a tagged file, so this removal is fine.

@wainersm wainersm merged commit 7f0bc34 into confidential-containers:main May 15, 2024
11 checks passed
@ldoktor
Copy link
Contributor

ldoktor commented May 16, 2024

Hi @ldoktor !

Yep, seems to cover all mentionings of ssh-demo here. Wainer, is your blog post updated, can we merge this?

On the blog post https://www.redhat.com/en/blog/how-use-confidential-containers-without-confidential-hardware luckily It points to a tagged file, so this removal is fine.

Thanks for the confirmation. Shouldn't the https://github.com/confidential-containers/confidential-containers/tree/main/demos/ssh-demo be removed too? (which would require the blog to be updated as well...)

Btw very nice blog post, I haven't read it before...

@fitzthum
Copy link
Member Author

Shouldn't the https://github.com/confidential-containers/confidential-containers/tree/main/demos/ssh-demo be removed too?

No. See commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants