tests: remove deprecated ansible option #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of ansible 2.11 the warn option was deprecated for the shell module. In ansible 2.14 it has been removed entirely making these playbooks inoperable. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
ldoktor
approved these changes
May 3, 2024
|
lgtm |
wainersm
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible used to have a "feature" where it would warn you if you wrote a shell command that could be implemented with a module instead. The shell option had an option to disable these warnings.
These features were deprecated in ansible 2.11 and removed in anbsible 2.14. This PR removes the warn option. Otherwise the playbooks won't work.
This does mean that people using an older version of ansible might see the warnings.