-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
payload: reuse supported_arches #372
payload: reuse supported_arches #372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice.
cc @portersrc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, this is exactly what I was thinking about while reviewing PR that touched this file. The only cons is that the purge_previous_manifests
clears all the manifests and not just the ones that will be re-created. As a result running this with both (x86_64 and s390x) and then re-running it with let's say only s390x the x86_64 manifest would be gone as well. Anyway I don't think it's a big deal... (but it adds to the question whether we need the purge_previous_manifests
at all)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
purge-previous-manifests looks odd to me on multiple levels. I would handle it in a different issue and cc me on it if it's irking you, @ldoktor 👍 |
supported_arches variable is defined but not used during manifest create step. With this patch we can easly disable arches for quick development test. Signed-off-by: Beraldo Leal <[email protected]>
1923189
to
5d9f0ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm now. Let me re-run the hanged job and merge it...
supported_arches variable is defined but not used during manifest create step. With this patch we can easly disable arches for quick development test.