Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: attempt to fix docker manifest commands #367

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Release: attempt to fix docker manifest commands #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions install/pre-install-payload/payload.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,18 @@ function build_payload() {
purge_previous_manifests "${registry}:${tag}"
purge_previous_manifests "${registry}:latest"

docker manifest create "${extra_docker_manifest_flags}" \
docker manifest create ${extra_docker_manifest_flags} \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here it is a good idea to drop the ${extra_docker_manifest_flags} quotes but keep the other ones

"${registry}:${tag}" \
"${registry}:x86_64-${tag}" \
"${registry}:s390x-${tag}"
--amend "${registry}:x86_64-${tag}" \
--amend "${registry}:s390x-${tag}"

docker manifest create "${extra_docker_manifest_flags}" \
docker manifest create ${extra_docker_manifest_flags} \
"${registry}:latest" \
"${registry}:x86_64-${tag}" \
"${registry}:s390x-${tag}"
--amend "${registry}:x86_64-${tag}" \
--amend "${registry}:s390x-${tag}"

docker manifest push "${extra_docker_manifest_flags}" "${registry}:${tag}"
docker manifest push "${extra_docker_manifest_flags}" "${registry}:latest"
docker manifest push ${extra_docker_manifest_flags} "${registry}:${tag}"
docker manifest push ${extra_docker_manifest_flags} "${registry}:latest"

popd
}
Expand Down
Loading