Include peerpod specific crd deployments via operator #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpradipt
requested review from
mythi,
jensfr and
stevenhorsman
and removed request for
mythi
mythi
reviewed
Feb 9, 2024
mythi
reviewed
Feb 9, 2024
mythi
reviewed
Feb 9, 2024
We can use 0.8.0. |
This includes peerpod and peerpodconfig controllers Signed-off-by: Cathy Avery <[email protected]> Signed-off-by: Pradipta Banerjee <[email protected]>
|
@mythi looks like you'll need to explicitly approve the PR for the approval to register |
mythi
approved these changes
Feb 9, 2024
|
The tests passed in the last nightly https://github.com/confidential-containers/operator/actions/runs/7838705386, so I'll re-queue in case that helps |
jensfr
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes peerpod and peerpodconfig controllers
This is based on @caavery work. I just rebased and adapted the code to align with latest code base