Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/git-helper.sh: fix yq checking #342

Merged
merged 1 commit into from
Jan 30, 2024
Merged

tests/git-helper.sh: fix yq checking #342

merged 1 commit into from
Jan 30, 2024

Conversation

wainersm
Copy link
Member

@wainersm wainersm commented Jan 29, 2024 •
edited
Loading

[ ! command -v jq &> /dev/null ] doesn't work for checking the existing of yq because if enclosed in [] it won't check the return code of command.

Found this problem when running the CI jobs for PR #338.
I don't know why on previous execution jq existed on the system so that we didn't catch the issue before.

@wainersm wainersm requested review from ldoktor and BbolroC January 29, 2024 14:20
@wainersm wainersm mentioned this pull request Jan 29, 2024
Merged
portersrc
portersrc approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@portersrc portersrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@GabyCT
Copy link
Contributor

GabyCT commented Jan 29, 2024

lgtm

ldoktor
ldoktor approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@ldoktor ldoktor requested a review from stevenhorsman January 30, 2024 16:30
stevenhorsman
stevenhorsman approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from possible typo fix (yq->jq) in the commit header, LGTM. Thanks

@ldoktor
Copy link
Contributor

ldoktor commented Jan 30, 2024

Apart from possible typo fix (yq->jq) in the commit header, LGTM. Thanks

Oh true, I missed that. @wainersm could you please update the commit message?

@wainersm
tests/git-helper.sh: fix jq checking
2306239 
`[ ! command -v jq &> /dev/null ]` doesn't work for checking the
existing of jq because if enclosed in `[]` it won't check the return
code of `command`.

Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
@wainersm
Copy link
Member Author

ops... fixed the commit message! Thanks @stevenhorsman !

@ldoktor ldoktor merged commit 97889bc into confidential-containers:main Jan 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenhorsman stevenhorsman stevenhorsman approved these changes

@ldoktor ldoktor ldoktor approved these changes

@portersrc portersrc portersrc approved these changes

@BbolroC BbolroC Awaiting requested review from BbolroC

Assignees
No one assigned
Labels
ok-to-test testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wainersm @GabyCT @ldoktor @portersrc @stevenhorsman